Issue52 : First method change for approuval #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job tackling #52 =) With all the tests using the new method name, I'm worried that using remove_access_vlan does not behave the way unset_access_vlan does. If you remove remove_access_vlan from switch base, I'm sure all the tests still pass. Also, I would like to know that a certain call is deprecated when I call it. Maybe a log message or something? |
|
LGTM. Once conflicts are resolved, will merge. |
# Conflicts: # netman/core/objects/switch_transactional.py
| from netman.core.objects.switch_base import SwitchOperations | ||
|
|
||
|
|
||
| class BackwardCompatiblieSwitchOperationsTest(TestCase): |
There was a problem hiding this comment.
Typo. I think it should be: BackwardsCompatibleSwitchOperationsTest
With that fix, also make sure the filename reflects the name to: backwards_compatible_switch_operations_test
There was a problem hiding this comment.
Oups!! Sorry! Fixing this right away!
|
👍 |
idjaw
added a commit
that referenced
this pull request
Feb 2, 2016
Issue52 : First method change for approuval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.